NIAD-3304: Allow non-SNOMEDCT codes to be preserved when mapping CodeableConcepts#1133
Merged
MartinWheelerMT merged 4 commits intomainfrom Mar 3, 2025
Merged
Conversation
MartinWheelerMT
changed the base branch from
main
to
niad-3304-add-functionality-for-non-snomed-codes
Base automatically changed from
niad-3304-add-functionality-for-non-snomed-codes
to
main
March 3, 2025 14:28
…CodeableConcept`s * Remove unnecessary non-snomed code systems from test files as the functionality has changed and are testing in a separate test * Update `CodeableConceptCdTemplateParameters` to include a property for translations. * Update `codeable_concept_cd_template.mustache` to handle translations. * Add test to ensure that non-snomed codes are populated as translations in the produced XML when a SNOMEDCT code is present. * Add functionality to `CodeableConceptCdMapper` to populate translations in the XML when non-SNOMEDCT codes have been provided alongside the SNOMEDCT Code.
…s are now being preserved.
MartinWheelerMT
force-pushed
the
niad-3304-add-functionality-for-non-snomed-codes-2
branch
from
a0ccc0e to
e1dac86
Compare
…ble "nonSnomedCodeCodings"
|
Looks good. All 24 mutations in this change were killed.
|
|
Bhavesh-Patel
approved these changes
Mar 3, 2025
MartinWheelerMT
deleted the
niad-3304-add-functionality-for-non-snomed-codes-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged after: PR-1126
This is the first PR for the new feature, there will be an additional PR for each of the non-standard
CodeableConceptCdmethods.What
CodeableConceptCdTemplateParametersto include a property for translations.codeable_concept_cd_template.mustacheto handle translations.CodeableConceptCdMapperto populate translations in the XML when non-SNOMEDCT codes have been provided alongside the SNOMEDCT Code.Why
The GP2GP Sending Adaptor does not currently preserve non-SNOMEDCT codes when mapping
CodeableConcepts.The GP2GP Request Adaptor does preserve this codes when a SNOMEDCT code is also present in the coding block.
It is necessary as part of FRA that these are preserved when transferring a patient out of NME system.
Type of change
Please delete options that are not relevant.
Checklist:
This is the first part of the change and documentation / change log will be updated once work is complete.